Replace @mui/x-data-grid with material-react-table #49
Conversation
|
Your Render PR Server URL is https://pulpito-ng-pr-49.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-cjbannfdb61s738ng31g. |
✅ Deploy Preview for pulpito ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
zmc
force-pushed
the
mrt
branch
2 times, most recently
from
b307b05 to
0c058f8
Compare
zmc
changed the title
Signed-off-by: Zack Cerza <[email protected]>
zmc
force-pushed
the
mrt
branch
2 times, most recently
from
93a3f11 to
802e5fd
Compare
|
Wow, this looks really amazing! I especially love this cool feature right here: |
zmc
force-pushed
the
mrt
branch
5 times, most recently
from
f8e8c21 to
5cb66c0
Compare
There was a problem hiding this comment.
/queue page seems to be giving some warning/error on development environment:
Uncaught TypeError: setter is not a function
at Object.onColumnFiltersChange (index.tsx:210:5)
at table.setColumnFilters (Filters.ts:584:21)
at column.setFilterValue (Filters.ts:470:13)
at handleClear (MRT_FilterTextField.tsx:183:14)
at MRT_FilterTextField.tsx:206:9
at commitHookEffectListMount (react-dom.development.js:23150:26)
at invokePassiveEffectMountInDEV (react-dom.development.js:25154:13)
at invokeEffectsInDev (react-dom.development.js:27351:11)
at commitDoubleInvokeEffectsInDEV (react-dom.development.js:27330:7)
at flushPassiveEffectsImpl (react-dom.development.js:27056:5)
Also, I'm not sure why but particular node pages like this https://pulpito-ng-pr-49.onrender.com/nodes/smithi001.front.sepia.ceph.com/ have tables which are not 100% in width:
Fixes: #61 Signed-off-by: Zack Cerza <[email protected]>
Signed-off-by: Zack Cerza <[email protected]>
This adds our former DataGrid theming into the theme itself. Signed-off-by: Zack Cerza <[email protected]>
Signed-off-by: Zack Cerza <[email protected]>
Fixes: #48 Signed-off-by: Zack Cerza <[email protected]>
Signed-off-by: Zack Cerza <[email protected]>
Signed-off-by: Zack Cerza <[email protected]>
Signed-off-by: Zack Cerza <[email protected]>
Signed-off-by: Zack Cerza <[email protected]>
Signed-off-by: Zack Cerza <[email protected]>
The name column will be shown when >1 nodes are being displayed The arch and machine_type columns will be shown when there are more than one unique value in the dataset Signed-off-by: Zack Cerza <[email protected]>
And use TypeScript. Signed-off-by: Zack Cerza <[email protected]>
zmc
force-pushed
the
mrt
branch
2 times, most recently
from
c1d551c to
636c8d4
Compare
Cells containing SVGs keep their original padding. Signed-off-by: Zack Cerza <[email protected]>
|
Thanks so much for the review @VallariAg! I've pushed some updates. Re: the blue rows, I think queued and waiting being blue is okay, since neither have actually run yet. Runs shouldn't have an unknown status, but that's clearly a bug we need to track down in paddles. I am not sure if having no background color is better, though. |
Ah okay, understood! The PR looks really great! Almost done, I just had 2 final comments that I would like your opinion on: |
Now that we have expandos, we don't need the tooltips. Signed-off-by: Zack Cerza <[email protected]>
Signed-off-by: Zack Cerza <[email protected]>
Signed-off-by: Zack Cerza <[email protected]>
Signed-off-by: Zack Cerza <[email protected]>
Signed-off-by: Zack Cerza <[email protected]>
Signed-off-by: Zack Cerza <[email protected]>
To pull in Vite PR #14756 to fix routing inconsistencies between dev and prod. Signed-off-by: Zack Cerza <[email protected]>
This is intended to fix #48 and #61
Current status: Porting complete. Expansions are implemented!